fix(auth): harden oauth device polling and add device-auth flag#83
Merged
Conversation
Handle OAuth 2.0 device-flow error fields (authorization_pending, slow_down, access_denied, expired_token) when polling token endpoints, decode JSON bodies even on non-2xx responses, and expose auth login --device-auth with updated docs and generated Skill guidance. Signed-off-by: samzong <samzong.lu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden OAuth 2.0 device-flow token polling to accept standard
errorfield values (authorization_pending,slow_down,access_denied,expired_token), decode JSON bodies on non-2xx responses, and addauth login --device-auth. Update README, CLI usage docs, and generated Skill guidance to reference the new flag.Verification
go test ./internal/auth/... ./internal/codegen/render/...Compatibility
auth login --device-auth(alias for OAuth device login; still accepts--auth-type oauth).authorization_pending.--auth-type oauthto--device-auth.Checklist
internal/generated/,.cache/, and ad-hocskills/<cli-name>/directories is not committed.