Pull pyca SHA3 OIDs #329
Draft
Pull pyca SHA3 OIDs #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fedora RPM build will fail as we have still the old version in rawhide. Filled https://bugzilla.redhat.com/show_bug.cgi?id=2395478 |
simo5
reviewed
Sep 15, 2025
Member
simo5
left a comment
simo5
left a comment
There was a problem hiding this comment.
I think we should get data_length() right if possible
Contributor
Author
|
changing to draft as bringing the new asn1 into fedora would need a compat package, which is not worth the hassle now. But I just wanted to keep a track of this so lets keep it in draft until we get Fedora updated. |
Contributor
Author
|
Rebased on top of recent changes. The python-cryptography landed so we can expect the rust-asn1 to be available any time soon: |
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Used version from commit 6131b24c1c05dda6b7f2d43ea935fa04a6eec20f mostly adding the NIST SHA3 OIDS Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Member
|
@Jakuje do you think this will work now? |
Contributor
Author
I think not (otherwise we would see failures in all the other pipelines). The rust-asn1 is still on 0.21: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pulls also the new version of asn1 crate. Unfortunately, its not backward compatible, but the mandatory API is safe to return None, which I reused here for simplicity.
Checklist
- [ ] Test suite updated with functionality tests- [ ] Test suite updated with negative tests- [ ] Rustdoc string were added or updated- [ ] CHANGELOG and/or other documentation added or updated- [ ] This is not a code changeReviewer's checklist: