Fix exemptions not possible to create on findings level (and activate for check 102)#1186
Fix exemptions not possible to create on findings level (and activate for check 102)#1186
Conversation
|
The attribute |
|
@jrodriguez-rc, can you please review my changes? Your change in #950 moved setting I didn't see the need for the attribute |
|
@ConjuringCoffee I just tried in 2025 release and the change is working correctly |
|
@jrodriguez-rc, thanks for the test. Do you see any problems with the new handling of the attribute |
|
Happy new year everyone. If @jrodriguez-rc doesn't have anything to add, then let's merge the pull request. 😉 |
|
yea, sounds good |
|
Hi @ConjuringCoffee, sorry for the delay. I don't see any problem about that. |
|
Thanks everyone |

Fixes #1183
It isn't simply enough to call method
ENABLE_CHECKSUMin the constructor. SAP standard requires setting the attributeUSES_CHECKSUMin the constructor for exemptions to work correctly.For now, I've changed
SET_USES_CHECKSUMfrom private to protected. Calling both methods in the constructor of the check works, but it is pretty ugly. I want to refactor how the methods are implemented.