Skip to content

Fix exemptions not possible to create on findings level (and activate for check 102)#1186

Merged
larshp merged 5 commits intomainfrom
exempt-finding-102
Jan 7, 2026
Merged

Fix exemptions not possible to create on findings level (and activate for check 102)#1186
larshp merged 5 commits intomainfrom
exempt-finding-102

Conversation

@ConjuringCoffee
Copy link
Copy Markdown
Collaborator

Fixes #1183

It isn't simply enough to call method ENABLE_CHECKSUM in the constructor. SAP standard requires setting the attribute USES_CHECKSUM in the constructor for exemptions to work correctly.

For now, I've changed SET_USES_CHECKSUM from private to protected. Calling both methods in the constructor of the check works, but it is pretty ugly. I want to refactor how the methods are implemented.

@ConjuringCoffee
Copy link
Copy Markdown
Collaborator Author

The attribute USES_CHECKSUM used to be set in the constructor, but it was changed in #950.

@ConjuringCoffee
Copy link
Copy Markdown
Collaborator Author

@jrodriguez-rc, can you please review my changes? Your change in #950 moved setting USES_CHECKSUM out of the constructor which made it impossible to create exemptions on finding levels.

I didn't see the need for the attribute MV_USES_CHECKSUM. I've removed it and now only the standard attribute is used. The attribute is set in the constructor again.

@ConjuringCoffee ConjuringCoffee marked this pull request as ready for review November 25, 2025 12:53
@ConjuringCoffee ConjuringCoffee changed the title CHECK_102: Activate exemptions on finding level Fix exemptions not possible to create on findings level (and activate for check 102) Nov 25, 2025
@jrodriguez-rc
Copy link
Copy Markdown
Collaborator

jrodriguez-rc commented Nov 27, 2025

@ConjuringCoffee I just tried in 2025 release and the change is working correctly
{0AF6D41C-7B53-48B4-BF88-AE5375A0FB59}

@ConjuringCoffee
Copy link
Copy Markdown
Collaborator Author

@jrodriguez-rc, thanks for the test. Do you see any problems with the new handling of the attribute USES_CHECKSUM? I'm asking because it reverts some of your changes,

@ConjuringCoffee
Copy link
Copy Markdown
Collaborator Author

Happy new year everyone. If @jrodriguez-rc doesn't have anything to add, then let's merge the pull request. 😉

@larshp
Copy link
Copy Markdown
Owner

larshp commented Jan 2, 2026

yea, sounds good

@jrodriguez-rc
Copy link
Copy Markdown
Collaborator

Hi @ConjuringCoffee, sorry for the delay. I don't see any problem about that.

@larshp larshp merged commit bb92457 into main Jan 7, 2026
2 checks passed
@larshp larshp deleted the exempt-finding-102 branch January 7, 2026 09:26
@ConjuringCoffee
Copy link
Copy Markdown
Collaborator Author

Thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable exemptions on finding level (at least for check 102)

3 participants