Test and document field reorder safety in tables.toml#151
Merged
Conversation
Lock in the property that field declaration order in `tables.toml` is cosmetic: when the underlying CSV is unchanged but the operator swaps fields in the config between two blocks, the resulting patch carries no inserts, deletes, or updates, and survives a wire round-trip. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Note in README.md that when `header = true`, reordering fields in the config does not invalidate existing state. Update the layout-change description in CONTRIBUTING.md to refer to the canonical field list (primary keys first, then subsidiaries; each group sorted lexicographically by name) and to call out that reordering is a no-op while add/remove/rename still triggers the full-state fallback. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
`recognised` -> `recognized`, `honoured` -> `honored`, matching the American-English spelling convention used elsewhere in the project. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/accept_field_reorder.rs) that reorders fields intables.tomlbetween two blocks with an unchanged CSV and asserts the resulting patch carries no inserts, deletes, or updates and survives a wire round-trip. Locks in the property shipped in Fix record corruption when fields are reordered in table config #150.README.mdto note that, whenheader = true, the order in which fields are declared under a table is cosmetic and reordering them does not invalidate existing state. Also fix two British spellings in the boolean-sentinel paragraph (recognised→recognized,honoured→honored).CONTRIBUTING.mdto describe layout-change detection in terms of the canonical field list (primary keys first, then subsidiaries; each group sorted lexicographically by name) and to call out that reordering is a no-op while add/remove/rename still triggers the full-state fallback.