Merged
Conversation
Drop make_table_config (only two callers, easier to inline) and collapse make_field down to (name, primary_key) — value_kind and null_sentinel were never load-bearing for the ordered_field_names tests, and four positional args made call sites hard to scan. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Replace explicit max_field_length/include/exclude defaults with struct update syntax so each test shows only the fields it exercises. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
e252898 to
bad81f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary