Skip to content

perf: lazy-load sheets shortcuts by invocation#1249

Closed
fangshuyu-768 wants to merge 1 commit into
feat/lark-sheets-refactor-backward-compatiblefrom
feat/lazy-load-sheets-shortcuts
Closed

perf: lazy-load sheets shortcuts by invocation#1249
fangshuyu-768 wants to merge 1 commit into
feat/lark-sheets-refactor-backward-compatiblefrom
feat/lazy-load-sheets-shortcuts

Conversation

@fangshuyu-768
Copy link
Copy Markdown
Collaborator

Summary

Avoid loading the sheets shortcut registry and its embedded flag metadata on every lark-cli startup. Sheets shortcuts are now mounted only when the current invocation actually targets sheets (plus help sheets and shell completion paths).

Changes

  • Carry bootstrap positional args through InvocationContext
  • Keep sheets shortcuts out of the global shortcut init path
  • Register sheets shortcuts conditionally based on the current invocation
  • Add tests for bootstrap arg capture and sheets shortcut registration gating

Test Plan

  • go test ./cmd ./shortcuts

Notes

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b86e75cf-e7fe-424f-8bd8-c3bd42cf6fb0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/lazy-load-sheets-shortcuts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/L Large or sensitive change across domains or core paths label Jun 3, 2026
@fangshuyu-768 fangshuyu-768 force-pushed the feat/lazy-load-sheets-shortcuts branch from 3e96615 to 0efde2f Compare June 3, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Large or sensitive change across domains or core paths

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant