-
Notifications
You must be signed in to change notification settings - Fork 238
Upgrade to shadcn-vue v4 #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
All of the changes from single to double quotes make it extremely hard to tell what is actually changed here. 🫠 Can you only make this PR include the real changes? |
|
@taylorotwell You're absolutely right! 🙂 For example, see the To preserve the original Shadcn styling, the Starter Kit excludes all UI components from ESLint — so I believe this behavior is intentional. From a DX perspective, I think this is the best approach, as keeping the Shadcn styling unchanged helps avoid confusion when developers add or override components with newer Shadcn versions. If you’d prefer not to keep the original Shadcn components exactly as they are, just let me know, and I’ll apply ESLint fixes to the modified files. |
|
@geisi looks like you forgot to push. |
|
@hafezdivandari Sorry for the confusion, no, I did not forget to push any changes. The styling changes in the ui directory are intentional to follow the Shadcn Vue component structure and allow a cleaner upgrade path for future Shadcn Vue updates. If this is not wanted, I can try to apply the old styling, but then we won't be following the original Shadcn-Vue components anymore. |
|
Is there a linter config that can automatically fix single/double quotes? That might help this get merged sooner. |
|
Yes, as already mentioned, my question was whether I should change the styling of the ShadCN components. But I don't think it makes sense to change the styling here. We should follow the upstream component styling to improve DX when upgrading/adding new Shadcn components. Suppose starter kit users add new Shadcn components. In that case, their styling will differ from that of the components delivered with the starter kit, which will confuse developers and lead to inconsistent UI component styling. |
Hi Laravel team,
This PR updates the Laravel Vue Starter kit to the recently deployed v4 Version of Shadcn Vue.
unovue/shadcn-vue#1515
I think this is a good moment to do that, since Shadcn Vue has updated their docs to v4 only.
The legacy docs are still accessible here:
https://v3.shadcn-vue.com/
Without this change, developers will encounter errors when adding some Shadcn (e.g., Calendar) components or using code snippets from the docs.
Please note that the
defaultstyle is now deprecated with v4. That's why I have changed it tonew-yorkinstead.I have re-added all the components used from the starter kit. And tested the whole UI, everything works, and is now using the New York styling instead with v4 components.
I think this is the best baseline to prevent developer frustration when working with this starter kit.