[13.x] Expose new countColumns parameter to control the columns of getCountForPagination#60288
Closed
pfabri-ebrand wants to merge 1 commit into
Closed
Conversation
shaedrich
reviewed
May 27, 2026
Comment on lines
+992
to
+993
| * @param int|null|\Closure $total | ||
| * @param array $countColumns |
Contributor
There was a problem hiding this comment.
You may want to narrow this further down
Suggested change
| * @param int|null|\Closure $total | |
| * @param array $countColumns | |
| * @param int|null|\Closure(): int $total | |
| * @param array<int, string> $countColumns |
or
Suggested change
| * @param int|null|\Closure $total | |
| * @param array $countColumns | |
| * @param int|null|\Closure(): int $total | |
| * @param string[] $countColumns |
or
Suggested change
| * @param int|null|\Closure $total | |
| * @param array $countColumns | |
| * @param int|null|\Closure(): int $total | |
| * @param list<string> $countColumns |
Author
There was a problem hiding this comment.
I'm just matching the existing phpdoc style
Contributor
There was a problem hiding this comment.
There's always a chance to improve, but not if one always takes the worst example as their guiding principle 😉
Member
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The idea behind this PR is to be able to control the fields used by the
getCountForPagination/runPaginationCountQueryand have slightly better performant queries when the count is done on table with many fields