Logits processors: Update inplace, with batching#92
Open
lapp0 wants to merge 2 commits into
Open
Conversation
8aa0b0d to
094af23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
For
GuideLogitsProcessor,logitsinplace: 7514affBenchmarks for both changes
CI doesn't benchmark
torch_cuda, so I've included it here.Update
logitsinplacetime_structured_generation('numpy', 'Z*')time_structured_generation('torch', 'Z*')time_structured_generation('torch_cuda', 'Z*')time_structured_generation('torch_cuda', '[^Z]*')Batch update logits
time_structured_generation('numpy', '[^Z]*')time_structured_generation('torch', '[^Z]*')time_structured_generation('numpy', 'Z*')time_structured_generation('torch', 'Z*')time_structured_generation('torch_cuda', 'Z*')time_structured_generation('torch_cuda', '[^Z]*')Testing
test_generate.pywith CUDA modelsFurther Work
RegexGuidelegal token mask on GPU to improvetime_structured_generation('torch', '[^Z]*'). In this benchmark,allowed_tokensis all tokens exceptZ,ZZ, andZZZ, resulting in a largeLongTensorbeing sent to GPU each step.