Refactor json_schema.py to_regex as a class, subclass to allow YAML generation#36
Draft
lapp0 wants to merge 1 commit into
Draft
Refactor json_schema.py to_regex as a class, subclass to allow YAML generation#36lapp0 wants to merge 1 commit into
json_schema.py to_regex as a class, subclass to allow YAML generation#36lapp0 wants to merge 1 commit into
Conversation
9648b30 to
3efb728
Compare
3efb728 to
99fa1ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Refactor
json_schema.pyto be more coherent and extensible. Use extensibility to implement JSON Schema to yaml.Changes
TODO, finish this section
Behavioral Changes
A number of changes have been made to conform with the JSON Schema spec.
This needs to be part of the release notes and documentation
including but not limited to:
anyOf: Previously brokenallOf: Previously brokenoneOf: Disabled, not feasibleJSON Schema Compliance
This is a large change-set. To verify correctness, in addition to ensuring current tests pass,
test_json_schema_full.pytests compliance with JSON Schema by retrieving 1,245 test cases from the official json-schema.org test suite.On this Branch
NotImplementedErrorOn
mainTODO
json_schemaso its clean and extensibleFurther Work
NotImplementedErrorconditions. There are ~20 (mostly different key types)