Skip to content

fix(print): rename PRINT_CREATE_CLIENT value to avoid enum aliasing #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laniakea2006 merged 2 commits into from
Jun 10, 2026
Merged

fix(print): rename PRINT_CREATE_CLIENT value to avoid enum aliasing #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8e9c81
fix(print): rename PRINT_CREATE_CLIENT value to avoid enum aliasing
laniakea2006 Jun 10, 2026
b4003b4
chore(print): bump version to 0.26.0
laniakea2006 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "sap-cloud-sdk"
version = "0.24.1"
version = "0.26.0"
description = "SAP Cloud SDK for Python"
readme = "README.md"
license = "Apache-2.0"
Expand Down
2 changes: 1 addition & 1 deletion src/sap_cloud_sdk/core/telemetry/operation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class Operation(str, Enum):
PRINT_GET_PROFILES = "get_print_profiles"
PRINT_UPLOAD_DOCUMENT = "upload_document"
PRINT_CREATE_TASK = "create_print_task"
PRINT_CREATE_CLIENT = "create_client"
PRINT_CREATE_CLIENT = "print_create_client"

# DMS Operations
DMS_ONBOARD_REPOSITORY = "onboard_repository"
Expand Down
4 changes: 2 additions & 2 deletions tests/core/unit/telemetry/test_operation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def test_dms_operations(self):

def test_print_operations(self):
"""Test Print operation values."""
assert Operation.PRINT_CREATE_CLIENT.value == "create_client"
assert Operation.PRINT_CREATE_CLIENT.value == "print_create_client"
assert Operation.PRINT_LIST_QUEUES.value == "list_queues"
assert Operation.PRINT_CREATE_QUEUE.value == "create_queue"
assert Operation.PRINT_GET_PROFILES.value == "get_print_profiles"
Expand Down Expand Up @@ -212,4 +212,4 @@ def test_operation_count(self):
all_operations = list(Operation)
# 3 auditlog + 11 destination + 10 certificate + 10 fragment + 8 objectstore
# + 2 extensibility + 2 aicore + 23 dms + 4 agentgateway + 13 agent_memory + 5 data anonymization + 6 print = 97
assert len(all_operations) == 96
assert len(all_operations) == 97
Loading