fix: data layer — cache TTL NaN bug + synth error guard#205
Open
kingmylord wants to merge 1 commit intolangoustine69:mainfrom
Open
fix: data layer — cache TTL NaN bug + synth error guard#205kingmylord wants to merge 1 commit intolangoustine69:mainfrom
kingmylord wants to merge 1 commit intolangoustine69:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Bug fixes
cache.ts: TTL NaN when env var unsetNumber(undefined)returnsNaN, andNaN ?? 300still returnsNaN(nullish coalescing only catchesnull/undefined). In production with noCACHE_TTL_SECONDSset, cache entries never expired silently.Fix: Use
Number.isFinite()guard before applying the 300s default.synth.ts: empty OpenAI response guardAdded explicit check for empty content in OpenAI response to fail fast with a clear error.
Tests added
cache.test.ts: verify default 300s TTL works with no args and no env varcache.test.ts: verifyCACHE_TTL_SECONDSenv var is respectedsynth.test.ts: single source scores lower than multiple sourcesAll 34 tests pass.