refactor(nodes)!: align node initialization signatures#39
Merged
Conversation
Normalize node constructors around typed node data configs and explicit dependency injection. Update direct construction sites in tests and examples to match the unified initialization pattern.
Add a discoverable classmethod for converting Python mappings into typed node data without reopening node constructors to raw mapping inputs.
WH-2099
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
!Related Issue
Closes #38
Summary
Nodeand concrete node constructors aroundnode_id, typed*NodeDataconfigs, and explicit injected dependenciesToolNodeandHumanInputNoderuntime requirements explicit while preserving thenode_idpublic parameter name{"id", "data"}wrappersnode_idand node data validation runs on the typed config payloadThis is a breaking API change for downstream callers that construct nodes directly with raw
NodeConfigDictpayloads or omit required runtime collaborators for tool and human-input nodes. The root cause is that node construction had diverged between the base class, concrete nodes, and direct call sites.Checklist
!