feat(cli): Add node permission management commands#602
feat(cli): Add node permission management commands#602zhuzihao-hz wants to merge 1 commit intolanggenius:mainfrom
Conversation
Summary of ChangesHello @zhuzihao-hz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the command-line interface by integrating comprehensive node permission management. It provides users with the ability to directly configure whether nodes can be invoked within Dify's ChatFlow and Workflow features, streamlining administrative tasks from the terminal. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for managing node permissions in the CLI. The changes are well-implemented and consistent with the existing code structure for other permission types. I've added one comment regarding code duplication in the edit method, which could be addressed in a future refactoring to improve long-term maintainability. Overall, the changes look good and address the feature requirement effectively.
| if p.cursor == "node.enabled" { | ||
| if p.permission.AllowInvokeNode() { | ||
| p.permission.Node = nil | ||
| } else { | ||
| p.permission.Node = &plugin_entities.PluginPermissionNodeRequirement{ | ||
| Enabled: true, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This logic for toggling a boolean permission is almost identical to the logic for other permissions (e.g., app.enabled). This code duplication makes the edit function longer and harder to maintain with each new permission.
To improve maintainability, consider abstracting this repeated pattern. A future refactoring could introduce a helper function or a map-based dispatcher to handle these simple toggle cases, reducing redundancy and making the code more scalable.
Description
Add support for setting node permissions through the CLI, enabling users to configure node permissions directly from the command-line interface.
Type of Change
Essential Checklist
Testing
Additional Information