Supports local debugging on Windows systems

[shootercheng]

Description

Supports local debugging on Windows systems

Type of Change

• Bug fix
• [ ✔] New feature
• Refactor
• Performance improvement
• Other

Essential Checklist

Testing

• [✔ ] I have tested the changes locally and confirmed they work as expected
• [✔ ] I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

• I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

[gemini-code-assist]

Summary of Changes

Hello @shootercheng, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's compatibility with Windows operating systems, specifically enabling local debugging capabilities. It achieves this by introducing a new system utility package that centralizes OS-specific logic for path handling, environment variable configuration, and Python virtual environment management. These changes ensure that the application behaves correctly and consistently across different platforms, particularly addressing the unique requirements of Windows for file paths and process execution.

Highlights

• Windows Compatibility for Python Environment: Introduced OS-specific logic for Python virtual environment paths, ensuring that the correct Python executable is located on Windows systems (e.g., Scripts/python.exe instead of bin/python).
• Dynamic Path Delimiter: Replaced the hardcoded colon (:) delimiter in plugin identifiers with a dynamic DelimiterFLag that adapts to the operating system, using # for Windows and : for other systems to prevent path conflicts.
• Path Normalization and Environment Variables: Implemented path normalization utilities to handle Windows-specific path formats and added support for setting TEMP and TMP environment variables based on a new TempDir configuration, crucial for temporary file handling on Windows.
• OpenTelemetry Dependency Update: Updated the go.mod file to explicitly include go.opentelemetry.io/otel/trace as a direct dependency.
• Context Handling for Windows: Modified installDependencies and preCompile functions to use context.Background() on Windows, potentially addressing context cancellation issues specific to that OS.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• .env.example
  • Added TEMP_DIR, PYTHONIOENCODING, LANG, and LC_ALL environment variables for Windows compatibility.
• go.mod
  • Promoted go.opentelemetry.io/otel/trace to a direct dependency.
• internal/core/local_runtime/setup_python_environment.go
  • Imported runtime and system packages.
  • Modified installDependencies and preCompile to use context.Background() on Windows.
  • Added TEMP and TMP environment variables based on appConfig.TempDir.
  • Updated envPythonPath initialization to use system.GetEnvPythonPath for OS-specific Python executable paths.
• internal/core/plugin_manager/media_transport/installed_bucket.go
  • Imported system package.
  • Used system.ConvertPath for path normalization when listing installed plugins.
• internal/types/app/config.go
  • Added TempDir field to the Config struct, allowing configuration of a temporary directory.
• pkg/entities/plugin_entities/identity.go
  • Imported system package.
  • Replaced hardcoded : delimiter with system.DelimiterFLag in plugin identifier parsing and formatting.
• pkg/entities/plugin_entities/identity_test.go
  • Updated test cases to use system.DelimiterFLag for plugin identifiers.
• pkg/plugin_packager/decoder/zip.go
  • Imported system package.
  • Used system.GetZipReadPath for OS-aware zip file path handling.
• pkg/utils/parser/identity.go
  • Imported system package.
  • Used system.DelimiterFLag in MarshalPluginID function for consistent plugin ID serialization.
• pkg/utils/system/system.go
  • Added new file system.go to encapsulate OS-specific utilities.
  • Defined DelimiterFLag (conditional on OS: # for Windows, : otherwise).
  • Provided ConvertPath for Windows path normalization.
  • Provided GetZipReadPath for OS-specific zip file path handling.
  • Provided GetEnvPythonPath for OS-specific Python executable path resolution.

Activity

• The pull request was created by shootercheng.
• The author explicitly stated the purpose: 'Supports local debugging on Windows systems'.
• The change is categorized as a 'New feature'.
• The author has confirmed local testing and that unit tests pass.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for local debugging on Windows systems, which is a valuable enhancement. The changes involve updating environment variables, modifying path handling logic, and adjusting tracing context for Windows. While the overall goal is positive, there are some critical issues identified in the path manipulation utilities that need immediate attention to ensure correct functionality on Windows. Additionally, the change in tracing context for Windows operations should be reviewed for its implications.

[shootercheng]

ok