fix: use context.Background() for trace context in LaunchLocalPlugin

[maniknarang]

Description

Bug was introduced in PR #583

When plugins are installed via HTTP API, the request context passed to LaunchLocalPlugin gets stored via runtime.SetTraceContext(ctx). This context is cancelled when the HTTP response is sent, but environment initialization continues asynchronously. This causes exec.CommandContext to fail immediately with "context canceled" during dependency installation.

This fix changes SetTraceContext(ctx) to SetTraceContext(context.WithoutCancel(ctx)).

Before

After

Type of Change

• Bug fix
• New feature
• Refactor
• Performance improvement
• Other

Testing

• I have tested the changes locally and confirmed they work as expected
• I have added unit tests where necessary and they pass successfully

[gemini-code-assist]

Summary of Changes

Hello @maniknarang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug where the asynchronous environment initialization for locally launched plugins would fail if the original request context was cancelled before the initialization completed. By ensuring that the trace context used for environment setup is independent of the request lifecycle, the plugin installation process is now more resilient and reliable.

Highlights

• Context Handling Fix: Replaced the request context (ctx) with context.Background() when setting the trace context in LaunchLocalPlugin. This change prevents plugin environment initialization from failing due to premature context cancellation when plugins are installed via HTTP API.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• internal/core/control_panel/launcher_local.go
  • Modified the LaunchLocalPlugin function to use context.Background() instead of the incoming ctx when calling runtime.SetTraceContext. This ensures that the trace context for environment initialization spans is not prematurely cancelled.

Activity

• The pull request addresses a bug introduced in PR feat: support opentelemetry #583.
• The author has confirmed local testing of the changes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a bug where an asynchronous task was prematurely cancelled due to using a request-scoped context. While the fix correctly uses context.Background() to prevent cancellation, it unfortunately discards important trace and identity information. This loss impacts the auditability of the plugin installation process and reduces observability across the asynchronous boundary. It is recommended to use context.WithoutCancel(ctx) to preserve context values while ignoring the cancellation signal, thereby maintaining auditability and observability.

[maniknarang]

Hi @Yeuoly, may I please get a review