feat : Add Max Completion Tokens for reasoning models#486
feat : Add Max Completion Tokens for reasoning models#486chupark wants to merge 2 commits intolanggenius:mainfrom
Conversation
add MAX_COMPLETION_TOKENS
Summary of ChangesHello @chupark, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the configuration options for reasoning models by adding a new parameter, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new model parameter, max_completion_tokens, for reasoning models. The change is straightforward, adding a new constant and its corresponding parameter rule template. My review focuses on a maintainability concern regarding significant code duplication between the new MAX_COMPLETION_TOKENS rule and the existing MAX_TOKENS rule. Addressing this would improve the long-term health of the codebase.
Description
Please provide a brief description of the changes made in this pull request.
Please also include the issue number if this is related to an issue using the format
Fixes #123orCloses #123.Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information
PR for blow
Please provide any additional context that would help reviewers understand the changes.