Skip to content

fix: Adjust the email sending validation logic and optimize error messages#2465

Merged
crazywoola merged 5 commits intolanggenius:mainfrom
WangYuhang-CN:main
Feb 10, 2026
Merged

fix: Adjust the email sending validation logic and optimize error messages#2465
crazywoola merged 5 commits intolanggenius:mainfrom
WangYuhang-CN:main

Conversation

@WangYuhang-CN
Copy link
Copy Markdown
Contributor

Related Issues or Context

#2460

This PR contains Changes to Non-Plugin

  • Documentation
  • Other

This PR contains Changes to Non-LLM Models Plugin

  • I have Run Comprehensive Tests Relevant to My Changes

This PR contains Changes to LLM Models Plugin

  • My Changes Affect Message Flow Handling (System Messages and User→Assistant Turn-Taking)
  • My Changes Affect Tool Interaction Flow (Multi-Round Usage and Output Handling, for both Agent App and Agent Node)
  • My Changes Affect Multimodal Input Handling (Images, PDFs, Audio, Video, etc.)
  • My Changes Affect Multimodal Output Generation (Images, Audio, Video, etc.)
  • My Changes Affect Structured Output Format (JSON, XML, etc.)
  • My Changes Affect Token Consumption Metrics
  • My Changes Affect Other LLM Functionalities (Reasoning Process, Grounding, Prompt Caching, etc.)
  • Other Changes (Add New Models, Fix Model Parameters etc.)

Version Control (Any Changes to the Plugin Will Require Bumping the Version)

  • I have Bumped Up the Version in Manifest.yaml (Top-Level Version Field, Not in Meta Section)

Dify Plugin SDK Version

  • I have Ensured dify_plugin>=0.3.0,<0.6.0 is in requirements.txt (SDK docs)

Environment Verification (If Any Code Changes)

Local Deployment Environment

  • Dify Version is: , I have Tested My Changes on Local Deployment Dify with a Clean Environment That Matches the Production Configuration.

SaaS Environment

  • I have Tested My Changes on cloud.dify.ai with a Clean Environment That Matches the Production Configuration

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 21, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @WangYuhang-CN, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the email sending functionality by implementing more precise validation for sender email addresses and improving the clarity of associated error messages. The changes ensure that email credentials are correctly formatted and provide users with actionable feedback when issues arise, ultimately enhancing the reliability and user experience of the email tool.

Highlights

  • Enhanced Email Validation: The email sending logic now includes more robust validation for both sender_address and email_account credentials, ensuring proper email format before sending.
  • Improved Error Messages: Error messages for invalid email addresses have been optimized to provide clearer guidance, distinguishing between sender_address and email_account issues and suggesting how to bypass validation.
  • Plugin Version Update: The email tool plugin version has been incremented from 0.0.9 to 0.0.10 in manifest.yaml to reflect these changes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot Bot added the bug Something isn't working label Jan 21, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the email validation logic for sending emails, which is a good improvement. It now correctly validates the sender_address if provided, falling back to the email_account otherwise. The error messages are also more descriptive. I've noticed a small inconsistency in the implementation between send_mail.py and send_mail_batch.py regarding a redundant check, and I've left a comment with a suggestion to align them.

Comment thread tools/email/tools/send_mail_batch.py
Copy link
Copy Markdown
Contributor Author

@WangYuhang-CN WangYuhang-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Feb 10, 2026
@crazywoola crazywoola merged commit f980d30 into langgenius:main Feb 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants