fix(langchain): escape empty json braces in prompts#1734
Open
sjsjsjjs534 wants to merge 1 commit into
Open
Conversation
|
zhangsixiao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes langfuse/langfuse#14721
Verification
Greptile Summary
This PR fixes a crash when Langfuse prompts containing bare empty JSON objects (
{},{ }, or{\n}) are converted for use with LangChain. Previously, an empty{}would reach LangChain as an unescaped single-brace pair, causing anIndexErrorduring.format().langfuse/model.py): A one-character addition —"}"is added to the lookahead set that classifies an opening{as JSON-related, so empty objects are now doubled to{{}}before reaching LangChain's template formatter.{},{ },{\n}) mixed with both Langfuse-style ({{test_var}}) and LangChain-style ({langchain_var}) variables in a single prompt.Confidence Score: 5/5
Safe to merge — the change is minimal and targeted, and the added test directly reproduces the previously crashing scenario.
The logic change is a single-character addition to a lookahead character set inside a well-isolated static method. Adding
}to the set that marks an opening brace as JSON-related correctly handles all three empty-object forms. Existing behaviour for non-empty JSON objects and LangChain variable placeholders is unaffected.No files require special attention.
Reviews (1): Last reviewed commit: "fix(langchain): escape empty json braces..." | Re-trigger Greptile