feat(api): update API spec from langfuse/langfuse 83d3009331ce11dc5fda825bc4dd5d4ced913a53#1352
Closed
maxdeichmann wants to merge 1 commit into
Closed
Conversation
…a825bc4dd5d4ced913a53
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+20
to
+25
| if self is BlobStorageIntegrationType.S_3: | ||
| return s_3() | ||
| if self is BlobStorageIntegrationType.S_3_COMPATIBLE: | ||
| return s_3_compatible() | ||
| if self is BlobStorageIntegrationType.AZURE_BLOB_STORAGE: | ||
| return azure_blob_storage() |
Contributor
There was a problem hiding this comment.
logic: Missing fallback case - method could return None if enum has unexpected value, violating return type annotation
Comment on lines
+19
to
+25
| ) -> T_Result: | ||
| if self is BlobStorageIntegrationFileType.JSON: | ||
| return json() | ||
| if self is BlobStorageIntegrationFileType.CSV: | ||
| return csv() | ||
| if self is BlobStorageIntegrationFileType.JSONL: | ||
| return jsonl() |
Contributor
There was a problem hiding this comment.
logic: Missing fallback case in visit method - if an unexpected enum value exists, this method will return None instead of T_Result, potentially causing runtime errors
Comment on lines
+14
to
+25
| def visit( | ||
| self, | ||
| full_history: typing.Callable[[], T_Result], | ||
| from_today: typing.Callable[[], T_Result], | ||
| from_custom_date: typing.Callable[[], T_Result], | ||
| ) -> T_Result: | ||
| if self is BlobStorageExportMode.FULL_HISTORY: | ||
| return full_history() | ||
| if self is BlobStorageExportMode.FROM_TODAY: | ||
| return from_today() | ||
| if self is BlobStorageExportMode.FROM_CUSTOM_DATE: | ||
| return from_custom_date() |
Contributor
There was a problem hiding this comment.
logic: Missing fallback case in visit method - if self doesn't match any of the enum values, the method will implicitly return None instead of T_Result, violating the return type annotation
Suggested change
| def visit( | |
| self, | |
| full_history: typing.Callable[[], T_Result], | |
| from_today: typing.Callable[[], T_Result], | |
| from_custom_date: typing.Callable[[], T_Result], | |
| ) -> T_Result: | |
| if self is BlobStorageExportMode.FULL_HISTORY: | |
| return full_history() | |
| if self is BlobStorageExportMode.FROM_TODAY: | |
| return from_today() | |
| if self is BlobStorageExportMode.FROM_CUSTOM_DATE: | |
| return from_custom_date() | |
| def visit( | |
| self, | |
| full_history: typing.Callable[[], T_Result], | |
| from_today: typing.Callable[[], T_Result], | |
| from_custom_date: typing.Callable[[], T_Result], | |
| ) -> T_Result: | |
| if self is BlobStorageExportMode.FULL_HISTORY: | |
| return full_history() | |
| if self is BlobStorageExportMode.FROM_TODAY: | |
| return from_today() | |
| if self is BlobStorageExportMode.FROM_CUSTOM_DATE: | |
| return from_custom_date() | |
| raise ValueError(f"Unknown BlobStorageExportMode: {self}") |
Comment on lines
+19
to
+25
| ) -> T_Result: | ||
| if self is BlobStorageExportFrequency.HOURLY: | ||
| return hourly() | ||
| if self is BlobStorageExportFrequency.DAILY: | ||
| return daily() | ||
| if self is BlobStorageExportFrequency.WEEKLY: | ||
| return weekly() |
Contributor
There was a problem hiding this comment.
logic: Missing fallback case in visit method - if an unexpected enum value exists, this method will implicitly return None instead of T_Result, violating the return type annotation
Suggested change
| ) -> T_Result: | |
| if self is BlobStorageExportFrequency.HOURLY: | |
| return hourly() | |
| if self is BlobStorageExportFrequency.DAILY: | |
| return daily() | |
| if self is BlobStorageExportFrequency.WEEKLY: | |
| return weekly() | |
| ) -> T_Result: | |
| if self is BlobStorageExportFrequency.HOURLY: | |
| return hourly() | |
| if self is BlobStorageExportFrequency.DAILY: | |
| return daily() | |
| if self is BlobStorageExportFrequency.WEEKLY: | |
| return weekly() | |
| raise ValueError(f"Unknown BlobStorageExportFrequency: {self}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR adds functionality for managing blob storage integrations and organization memberships, including new client methods and types, along with updated API documentation.
BlobStorageIntegrationsClientandAsyncBlobStorageIntegrationsClientinclient.pyfor managing blob storage integrations.get_blob_storage_integrations(),upsert_blob_storage_integration(), anddelete_blob_storage_integration().types/.OrganizationsClientandAsyncOrganizationsClientfor managing organization memberships.delete_organization_membership()anddelete_project_membership().DeleteMembershipRequestandMembershipDeletionResponsetypes.README.mdto correct a typo.test_http_client.pyandtest_query_encoding.pyfor consistency.This description was created by
for 42c4395. You can customize this summary. It will automatically update as commits are pushed.
Disclaimer: Experimental PR review
Greptile Summary
Updated On: 2025-09-17 15:44:07 UTC
This PR is an automated API specification update from the main Langfuse repository (commit 83d3009331ce11dc5fda825bc4dd5d4ced913a53) that introduces significant new functionality to the Python SDK. The changes are auto-generated by Fern from OpenAPI specifications, ensuring consistency between the backend API and client library.
Key additions include:
Blob Storage Integrations: A complete new API resource supporting S3, S3-compatible, and Azure Blob Storage integrations for automated data exports. This includes:
Organization Membership Management: Enhanced organization administration with new DELETE endpoints for removing memberships at both organization and project levels, including proper request/response types.
Enhanced Score Filtering: Added
session_idparameter to ScoreV2 endpoints, allowing more granular filtering of scores by session.Documentation Updates:
Structural Improvements: Core utilities have been moved from
langfuse.api.core.*tolangfuse.core.*, simplifying the module hierarchy.All changes follow established patterns in the codebase: Pydantic v1 models with proper field aliasing, consistent serialization methods, immutable configuration, and both sync/async client implementations. The auto-generated nature ensures type safety and maintains architectural consistency across the SDK.
Confidence score: 3/5