Skip to content

Update packaging#1262

Closed
jonaswinkler wants to merge 1 commit into
langfuse:mainfrom
jonaswinkler:feature/update-packaging
Closed

Update packaging#1262
jonaswinkler wants to merge 1 commit into
langfuse:mainfrom
jonaswinkler:feature/update-packaging

Conversation

@jonaswinkler

@jonaswinkler jonaswinkler commented Jul 21, 2025

Copy link
Copy Markdown

We'd like to use both langfuse as well as packaging==25.0, so it would be great if you could allow langfuse to install with this newer release of packaging.

Thank you!


Important

Update packaging dependency version range in pyproject.toml to >=23.2,<26.0.

  • Dependencies:
    • Update packaging version in pyproject.toml from >=23.2,<25.0 to >=23.2,<26.0.

This description was created by Ellipsis for 026c330. You can customize this summary. It will automatically update as commits are pushed.

Disclaimer: Experimental PR review

Greptile Summary

This PR requests a modification to allow langfuse to be compatible with packaging==25.0. This would be a dependency update that enables users to use both langfuse and the newer version of the packaging library in their projects. The packaging library is a core utility in Python's ecosystem used for parsing, managing and working with Python package versions and requirements.

Confidence score: 1/5

  • Safety: This PR cannot be safely merged as is
  • Reason: The PR describes a compatibility request but contains no actual code changes to implement it
  • Files needing attention: setup.py or pyproject.toml need to be modified to update dependency specifications

PR Description Notes:

  • The PR description clearly states the desired outcome but doesn't include any implementation

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Bot Settings | Greptile

@CLAassistant

CLAassistant commented Jul 21, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@hassiebp hassiebp self-assigned this Jul 21, 2025
@jkunstle

Copy link
Copy Markdown

We need this bump to happen. This currently breaks our tox workflow. If there wasn't a reason to upper-bound packaging I'd recommend unbounding it.

@hassiebp

Copy link
Copy Markdown
Collaborator

Thank you for your contribution @jonaswinkler ! Will be handled in #1273

@hassiebp hassiebp closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants