Skip to content

Fix: Table 'langchain_pg_collection' is already defined for this MetaData instance#209

Open
Rushi Chaudhari (0xrushi) wants to merge 5 commits intolangchain-ai:mainfrom
0xrushi:main
Open

Fix: Table 'langchain_pg_collection' is already defined for this MetaData instance#209
Rushi Chaudhari (0xrushi) wants to merge 5 commits intolangchain-ai:mainfrom
0xrushi:main

Conversation

@0xrushi
Copy link
Copy Markdown

@0xrushi Rushi Chaudhari (0xrushi) commented May 9, 2025 •
edited
Loading

Possible solution for #165

Added thread locks to prevent multi table creation, optionally we can also pass extend_existing = True if required.

vector_store = PGVector(
    embeddings=OpenAIEmbeddings(),
    collection_name="test_collection",
    connection=connection_string,
    extend_existing=True,
)

@0xrushi Rushi Chaudhari (0xrushi) mentioned this pull request May 9, 2025
Open
MartinGotelli
Martín Gotelli Ferenaz (MartinGotelli) reviewed May 9, 2025
View reviewed changes
Comment thread langchain_postgres/vectorstores.py Outdated
MartinGotelli
Martín Gotelli Ferenaz (MartinGotelli) reviewed May 9, 2025
View reviewed changes
Comment thread langchain_postgres/vectorstores.py Outdated
self._engine: Optional[Engine] = None
self._async_engine: Optional[AsyncEngine] = None
self._async_init = False
self.extend_existing = extend_existing
Copy link
Copy Markdown
Contributor

@MartinGotelli Martín Gotelli Ferenaz (MartinGotelli) May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a private variable self._extend_existing

Rushi Chaudhari (0xrushi) and others added 2 commits May 9, 2025 20:32
@0xrushi @MartinGotelli
Update langchain_postgres/vectorstores.py
4ed9b13 
Co-authored-by: Martín Gotelli Ferenaz <martingotelliferenaz@gmail.com>
make extend_existing private
c440575
@t-ionut
Copy link
Copy Markdown

Ionut Tolci (t-ionut) commented Sep 8, 2025

Martín Gotelli Ferenaz (@MartinGotelli) I've just encountered this exact issue in my work and I'm happy to see Rushi Chaudhari (@0xrushi) has a fix in this PR.

Any chance of getting this merged soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MartinGotelli Martín Gotelli Ferenaz (MartinGotelli) MartinGotelli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xrushi @t-ionut @MartinGotelli