add a new operator for array inclusion filtering#146
Open
SJ (sjjpo2002) wants to merge 1 commit intolangchain-ai:mainfrom
Open
add a new operator for array inclusion filtering#146SJ (sjjpo2002) wants to merge 1 commit intolangchain-ai:mainfrom
SJ (sjjpo2002) wants to merge 1 commit intolangchain-ai:mainfrom
Conversation
Eugene Yurtsev (eyurtsev)
requested changes
Feb 20, 2025
Collaborator
Eugene Yurtsev (eyurtsev)
left a comment
Eugene Yurtsev (eyurtsev)
left a comment
There was a problem hiding this comment.
Proposal for operator makes sense, but requires the following work:
- Differentiation between contains all vs. contains any.
- Unit tests for the given operator.
- PR summary that explains the semantics.
- Undoing unrelated code changes.
I may push a change for this in a bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to resolve the issue reported here:
#143