release_charts: Trivy CVE diff + send fixed_cves payload to changelog bot#711
Open
ashwinamardeep-ashwin wants to merge 1 commit into
Open
release_charts: Trivy CVE diff + send fixed_cves payload to changelog bot#711ashwinamardeep-ashwin wants to merge 1 commit into
ashwinamardeep-ashwin wants to merge 1 commit into
Conversation
… to changelog bot
At release time, scan docker.io/langchain/langsmith-backend at the
previous and new appVersion tags, set-diff High+Critical
VulnerabilityIDs, and POST {"fixed_cves_by_app_version": {<new>:
[...]}} to the changelog bot. The bot uses this in the ## Security
section for that helm version (see helm-changelog-bot#28); when the
payload is empty, the bot falls back to regex extraction over release
notes (see helm-changelog-bot#27).
Adds a workflow_dispatch input dry_run_cve_diff that computes the diff
but suppresses the payload, for safe end-to-end validation. Trivy
errors do not fail the chart release (continue-on-error). Scope is
langsmith-backend only for v1; siblings can be added later.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by: ashwinamardeep-ashwin
Companion PR: helm-changelog-bot#28. Both should land together; the bot side is backwards-compatible so order does not matter for safety.
Summary
At release time, scan `docker.io/langchain/langsmith-backend` at the previous and new `appVersion` tags, compute the set difference of HIGH+CRITICAL CVEs (before − after), and post that delta as JSON to the changelog bot's `/trigger`. The bot renders a per-version `## Security` block from the payload (or falls back to regex over release notes if no payload).
New steps inserted after `Run chart-releaser`, before `Trigger self-hosted changelog bot`:
Workflow_dispatch
Adds `dry_run_cve_diff: boolean` input. When `true`, the diff still runs and is logged, but the payload sent to the bot is `{}` — useful for end-to-end testing on a stable branch without affecting customer-facing changelog output.
Why scoped to one image for v1
The chart references 7+ service images (`langsmith-backend`, `langsmith-go-backend`, `langsmith-frontend`, `langsmith-playground`, `langsmith-ace-backend`, `langsmith-clio`, `hosted-langserve-backend`). Scanning all of them is straightforward to add as a matrix once this lands and we have signal that the rendered output looks right. Starting with backend keeps the failure surface small and the diff easy to validate.
Failure modes handled
Test plan