feat(langsmith): strip internal Envoy response headers (INF-2025)#707
Open
John Kennedy (jkennedyvz) wants to merge 7 commits into
Open
feat(langsmith): strip internal Envoy response headers (INF-2025)#707John Kennedy (jkennedyvz) wants to merge 7 commits into
John Kennedy (jkennedyvz) wants to merge 7 commits into
Conversation
…e stub (INF-2025)
…e headers (INF-2025)
…esponseHeaders (INF-2025) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rs is on (INF-2025) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
John Kennedy (jkennedyvz)
force-pushed
the
john/inf-2025-strip-internal-envoy-response-headers
branch
from
f6d8c42 to
8b9cb75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnvoyFilterto strip internal Envoy observability headers (x-envoy-upstream-service-time,x-envoy-decorator-operation) from gateway responses for self-hosted customers running Istio.istioGateway.stripResponseHeaders.{enabled,workloadSelector,headers}. Default: disabled. The defaultheaderslist closes the pentest finding without further configuration.validate.yamlrejects misconfiguration (toggle withoutistioGateway.enabled, emptyworkloadSelector, emptyheaders).Test plan
helm unittest charts/langsmith— 18/18 pass across 3 suites (existing + 5 new EnvoyFilter rendering tests + 3 new validation tests)helm templatewithistioGateway.stripResponseHeaders.enabled=truerenders a structurally correct EnvoyFilter (NETWORK_FILTER MERGE patch on http_connection_manager,response_headers_to_removepopulated)helm templatewith toggle on butistioGateway.enabled=falsefails with the validation errorcurl -iagainst any path shows neitherx-envoy-upstream-service-timenorx-envoy-decorator-operationin the response