fix(sdk): avoid unnecessary REMOVE_ALL_MESSAGES in PatchToolCallsMiddleware#1015
Closed
Christian Bromann (christian-bromann) wants to merge 4 commits intomainfrom
Closed
fix(sdk): avoid unnecessary REMOVE_ALL_MESSAGES in PatchToolCallsMiddleware#1015Christian Bromann (christian-bromann) wants to merge 4 commits intomainfrom
REMOVE_ALL_MESSAGES in PatchToolCallsMiddleware#1015Christian Bromann (christian-bromann) wants to merge 4 commits intomainfrom
Conversation
github-actions
Bot
added
the
deepagents
Mason Daugherty (mdrxy)
changed the title
REMOVE_ALL_MESSAGES in PatchToolCallsMiddlewareREMOVE_ALL_MESSAGES in PatchToolCallsMiddleware
langchain-automated-triage
Bot
added
the
internal
Merging this PR will not alter performance
Comparing 
Footnotes
|
…oolcall-fix # Conflicts: # libs/deepagents/deepagents/middleware/patch_tool_calls.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding to check whether we need to update the state if no dangling tool calls were found.
Overwrite is an explicit state replacement signal - When we return
{"messages": Overwrite(patched_messages)}, LangGraph will perform a state update operation, replacing the messages entirely. This happens regardless of whether the content is identical to what was already there.Returning
Noneseems a more performant approach.