refactor(namespace): remove table_version_storage_enabled and __manifest version storage#7222
Open
jackye1995 wants to merge 1 commit into
Open
Conversation
…est version storage __manifest cannot sustain per-commit version-write TPS; it suits table create/remove, not every commit. Remove the table_version_storage_enabled option and the entire __manifest-backed table-version path. Version list/create/describe/batch-delete now use the physical _versions/ directory exclusively, which was always the source of truth. Keep table_version_tracking_enabled (managed versioning) and manifest_enabled (table tracking); both are unaffected and served from physical storage. The multi-table transaction work that motivated version storage will be re-proposed separately.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
LuQQiu
approved these changes
Jun 12, 2026
LuQQiu
left a comment
LuQQiu
left a comment
Contributor
There was a problem hiding this comment.
agree that multi_table_transaction is still helpful but may be not this approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__manifestcannot sustain per-commit version-write TPS; it suits tablecreate/remove, not every commit. This removes the
table_version_storage_enabledoption and the entire
__manifest-backed table-version path. Versionlist/create/describe/batch-delete now use the physical
_versions/directoryexclusively, which was always the source of truth, so no data is lost.
Kept:
table_version_tracking_enabled(managed versioning) andmanifest_enabled(table tracking) — both unaffected and served from physical storage.
The multi-table transaction work that motivated version storage will be
re-proposed on a separate mechanism.