fix(python): python binding of Compaction.commit#7210
Open
gstamatakis95 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7209
python/src/dataset/optimize.rs:Compaction.commitgains an optionaloptionsdictparameter (
#[pyo3(signature = (dataset, rewrites, options = None))]), parsed through the sameparse_compaction_optionshelper thatplanandexecutealready use, seeded from thedataset's
manifest.configexactly likeexecute. Absent orNonepreserves the old behavior.The TODO comment is removed.
python/python/lance/lance/optimize.pyi: stub updated tocommit(dataset, rewrites, options: Optional[CompactionOptions] = None).python/python/tests/test_optimize.py: new parametrized testtest_defer_index_remap_via_commit_options. WithCompaction.commit(dataset, rewrites, options={"defer_index_remap": True})a__lance_frag_reusesystem index appears indescribe_indices(). Without options it does not(inline remap occurs). Mirrors the adjacent
test_defer_index_remapsetup.