feat: populate enriched IndexContent fields in dir namespace ListTableIndices#7109
Merged
Merged
Conversation
github-actions
Bot
added
A-deps
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
wjones127
force-pushed
the
namespace-index-content
branch
3 times, most recently
from
0f3407c to
e9280a2
Compare
…eIndices Previously the directory namespace's list_table_indices discarded everything from describe_indices except name/uuid/columns. Populate the enriched IndexContent fields from the IndexDescription already in hand, avoiding an N+1 DescribeTableIndexStats call per index: - index_type, type_url, num_indexed_rows, size_bytes, num_segments, created_at, index_version, index_details - num_unindexed_rows as count_rows() - rows_indexed(), matching how describe_table_index_stats computes it Bumps lance-namespace-reqwest-client to 0.8.4, which also adds a branch field to GetTableTagVersionResponse; get_table_tag_version now reads full TagContents via tags().get() to populate it. Closes lance-format#7101 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
wjones127
force-pushed
the
namespace-index-content
branch
from
e9280a2 to
a1856ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the directory namespace's
list_table_indicesdiscarded everything fromdescribe_indicesexceptname/uuid/columns. This populates the enrichedIndexContentfields from theIndexDescriptionalready in hand, avoiding an N+1DescribeTableIndexStatscall per index:index_type←index_type()type_url←type_url()num_indexed_rows←rows_indexed()num_unindexed_rows←count_rows() - rows_indexed(), matching howdescribe_table_index_statscomputes itsize_bytes←total_size_bytes()(staysNonefor legacy indices without file tracking)num_segments←segments().len()created_at← mincreated_atacross segments, RFC3339-formatted (staysNonefor legacy indices)index_version← first segment'sindex_versionindex_details←details().ok()dir.rsis the only backend in this repo that constructsIndexContent; the REST adapter lives in lance-namespace.test_list_table_indicesis extended to assert the new fields for both a scalar (BTree) and an IVF_FLAT vector index.Bumps
lance-namespace-reqwest-clientto 0.8.4, which also adds abranchfield toGetTableTagVersionResponse;get_table_tag_versionnow reads fullTagContentsviatags().get()to populate it.Closes #7101
🤖 Generated with Claude Code