Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ jobs:
if: inputs.release_type != 'current'
run: |
cargo check --manifest-path crates/lance-graph/Cargo.toml
cargo check --manifest-path python/Cargo.toml
cargo check --manifest-path crates/lance-graph-python/Cargo.toml

- name: Create release commit (when version changes)
if: inputs.release_type != 'current'
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Project Structure & Module Organization
- `crates/lance-graph/` hosts the Rust Cypher engine; keep new modules under `src/` and co-locate helpers inside `query/` or feature-specific submodules.
- `python/src/` contains the PyO3 bridge; `python/python/lance_graph/` holds the pure-Python facade and packaging metadata.
- `crates/lance-graph-python/src/` contains the PyO3 bridge; `python/python/lance_graph/` holds the pure-Python facade and packaging metadata.
- `python/python/tests/` stores functional tests; mirror new features with targeted cases here and in the corresponding Rust module.
- `examples/` demonstrates Cypher usage; update or add examples when introducing new public APIs.

Expand Down
122 changes: 122 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
members = [
"crates/lance-graph",
"crates/lance-graph-catalog",
]
exclude = [
"python",
"crates/lance-graph-python",
]
resolver = "2"
2 changes: 1 addition & 1 deletion python/Cargo.toml → crates/lance-graph-python/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ arrow-schema = "56.2"
arrow-ipc = "56.2"
datafusion = { version = "50.3", default-features = false }
futures = "0.3"
lance-graph = { path = "../crates/lance-graph" }
lance-graph = { path = "../lance-graph" }
serde = { version = "1", features = ["derive"] }
serde_json = "1"
pyo3 = { version = "0.25", features = ["extension-module", "abi3-py39", "py-clone"] }
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion docs/project_structure.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Suggested Migration Steps
3. Split the planner (`Cypher -> LogicalPlan`) into `lance-graph-planner`.
4. Refactor the Simple executor so it lives in the workspace cleanly (either
inside the facade crate or as a `lance-graph-simple` crate).
5. Update `python/Cargo.toml` to depend on the workspace crates.
5. Update `crates/lance-graph-python/Cargo.toml` to depend on the workspace crates.
6. Add ADRs for each step under `docs/` to document tradeoffs.
7. Update GitHub workflows to match the new workspace paths (build, test,
release/publish), otherwise releases will fail.
4 changes: 2 additions & 2 deletions examples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Pick one of the two approaches:
```bash
# From the repo root; installs the Python extension in editable mode
pip install pyarrow # or: uv pip install pyarrow
maturin develop -m python/Cargo.toml
maturin develop -m crates/lance-graph-python/Cargo.toml

# Run examples
python examples/basic_cypher.py
Expand All @@ -24,7 +24,7 @@ uv venv .venv && . .venv/bin/activate

# Install dependencies and build editable extension
uv pip install pyarrow
uvx --from maturin maturin develop -m python/Cargo.toml
uvx --from maturin maturin develop -m crates/lance-graph-python/Cargo.toml

# Run examples using the venv's Python
python examples/basic_cypher.py
Expand Down
2 changes: 1 addition & 1 deletion examples/basic_cypher.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

Requirements:
- Build/install the Python extension first (from repo root):
maturin develop -m python/Cargo.toml
maturin develop -m crates/lance-graph-python/Cargo.toml
- Python deps: pyarrow

Run:
Expand Down
2 changes: 1 addition & 1 deletion examples/kg_traversal.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

Requirements:
- Build/install the Python extension first (from repo root):
maturin develop -m python/Cargo.toml
maturin develop -m crates/lance-graph-python/Cargo.toml
- Python deps: pyarrow

Run:
Expand Down
Loading
Loading