test: add GIL release verification tests #132
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive tests to verify that the Python Global Interpreter Lock (GIL) is properly released during graph operations, addressing issue #97.
Findings
✅ The codebase already properly releases the GIL!
The existing
BackgroundExecutor(introduced inpython/src/executor.rs) correctly usespy.allow_threads()to release the GIL during all blocking operations:block_on()method releases GIL before blocking on futuresspawn()method releases GIL when spawning background tasksRT.block_on(Some(py), ...)which properly releases the GILTests Added
This PR adds verification tests to document and ensure this behavior continues:
CypherQuery.execute()CypherQuery.to_sql()CypherQuery.explain()Test Strategy
Each test:
If GIL was not released, the background thread would be starved and heartbeats would be 0.
Test Results
✅ All tests pass
Closes
Closes #97
🤖 Generated with Claude Code