feat(graph): split catalog crate#130
Merged
ChunxuTang merged 1 commit intolance-format:mainfrom Feb 12, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
beinan
commented
Feb 11, 2026
| ); | ||
| } | ||
| } | ||
| pub use lance_graph_catalog::DirNamespace; |
Collaborator
Author
There was a problem hiding this comment.
I will post another pr to remove this and change the import
beinan
commented
Feb 11, 2026
| self.schema.clone() | ||
| } | ||
| } | ||
| pub use lance_graph_catalog::{GraphSourceCatalog, InMemoryCatalog, SimpleTableSource}; |
Collaborator
Author
There was a problem hiding this comment.
I will post another pr to remove this and change the import
ChunxuTang
approved these changes
Feb 12, 2026
beinan
added a commit
to beinan/lance-graph
that referenced
this pull request
Feb 12, 2026
Remove redundant re-export modules (namespace/directory.rs and source_catalog.rs) and update all imports to use lance_graph_catalog directly. This addresses code review feedback from PR lance-format#130. Changes: - Remove crates/lance-graph/src/namespace/ directory - Remove crates/lance-graph/src/source_catalog.rs - Update lib.rs to re-export catalog types from lance_graph_catalog - Update all internal imports to use lance_graph_catalog - Update Python bindings to use new import paths Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
beinan
added a commit
that referenced
this pull request
Feb 12, 2026
## Summary Addresses code review feedback from PR #130 by removing redundant re-export modules and updating imports to use `lance_graph_catalog` directly. ## Changes - Removed `crates/lance-graph/src/namespace/` directory (only contained re-exports) - Removed `crates/lance-graph/src/source_catalog.rs` (only contained re-exports) - Updated `lib.rs` to re-export catalog types directly from `lance_graph_catalog` - Updated all internal imports in datafusion_planner, query, and Python bindings to use `lance_graph_catalog` ## Test plan - [x] `cargo check --all` passes - [x] `cargo test --all` passes (all 4 doc tests pass, all unit tests pass) Resolves review comments from #130 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lance-graph-catalogcrate for namespace/catalog utilitieslance-graphfor API compatibilityTesting