Skip to content

Conversation

@ChunxuTang
Copy link
Collaborator

This PR adds support for reusing variables across multiple patterns in a Cypher query without introducing duplicate column errors. It implements logic in the DataFusion planner to detect when a target variable in a pattern is already bound in the schema, and applies a filter constraint (e.g., prev.id = next.id) instead of performing a redundant join.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 88.00000% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tes/lance-graph/src/datafusion_planner/join_ops.rs 84.09% 14 Missing ⚠️
crates/lance-graph/src/logical_plan.rs 93.54% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ChunxuTang ChunxuTang merged commit 3df8175 into lance-format:main Feb 8, 2026
9 checks passed
@ChunxuTang ChunxuTang deleted the shared-var branch February 8, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants