Skip to content

refactor: remove the unused plan_with_context method #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChunxuTang merged 1 commit into from
Feb 2, 2026
Merged

refactor: remove the unused plan_with_context method #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions crates/lance-graph/src/datafusion_planner/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,45 +62,6 @@ impl DataFusionPlanner {
}
}

pub fn plan_with_context(
&self,
logical_plan: &LogicalOperator,
datasets: &std::collections::HashMap<String, arrow::record_batch::RecordBatch>,
) -> Result<LogicalPlan> {
use crate::source_catalog::{InMemoryCatalog, SimpleTableSource};

// Use the analyze() method to extract metadata
let analysis = analysis::analyze(logical_plan)?;

// Build an in-memory catalog from provided datasets (nodes and relationships)
let mut catalog = InMemoryCatalog::new();

// Register node sources from required datasets
for label in &analysis.required_datasets {
if self.config.node_mappings.contains_key(label) {
if let Some(batch) = datasets.get(label) {
let src = Arc::new(SimpleTableSource::new(batch.schema()));
catalog = catalog.with_node_source(label, src);
}
}
}

// Register relationship sources from required datasets
for rel_type in &analysis.required_datasets {
if self.config.relationship_mappings.contains_key(rel_type) {
if let Some(batch) = datasets.get(rel_type) {
let src = Arc::new(SimpleTableSource::new(batch.schema()));
catalog = catalog.with_relationship_source(rel_type, src);
}
}
}

// Plan using a planner bound to this catalog so scans get qualified projections
let planner_with_cat =
DataFusionPlanner::with_catalog(self.config.clone(), Arc::new(catalog));
planner_with_cat.plan(logical_plan)
}

/// Helper to convert DataFusion builder errors into GraphError::PlanError with context
pub(crate) fn plan_error<E: std::fmt::Display>(
&self,
Expand Down
Loading