fix: use list_tables() when available, table_names() is deprecated#56
Merged
gordonmurray merged 1 commit intoJun 10, 2026
Merged
Conversation
Newer lancedb deprecates table_names() in favor of list_tables(), which returns a ListTablesResponse with the names in .tables. The viewer supports versions back to 0.3.1 that only have table_names(), so /datasets picks whichever the connection provides. Fixes lance-format#54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Newer lancedb deprecates
table_names()in favor oflist_tables(), so/datasetswas logging a DeprecationWarning on 0.33.0 and will break outright whenever upstream removes the old method.list_tables()returns aListTablesResponsewith the names in.tables.Because the viewer supports lancedb versions back to 0.3.1 that only have
table_names(), this is a fallback rather than a straight replacement: uselist_tables()when the connection has it, otherwisetable_names().Test plan
Fixes #54