fix: check response.ok before parsing JSON in frontend fetch calls#49
Merged
gordonmurray merged 1 commit intoJun 10, 2026
Merged
Conversation
All five fetch() calls in app.js parsed the response body without checking the HTTP status, so a 4xx/5xx error response was treated as valid data and the UI broke further down. Throw on non-ok responses so failures land in the existing catch handlers and show the normal error messages. Fixes lance-format#27
gordonmurray
force-pushed
the
fix/27-response-ok-checks
branch
from
e558cee to
2a2048a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All five
fetch()calls inapp.jscalledresponse.json()without checking the HTTP status, so a 4xx/5xx response got parsed as if it were real data and the UI broke in confusing ways further down. Each call now throws on!response.ok, which lands in the existing catch handlers and shows the normal error messages ("Failed to load data", "Connection Error", etc).Corrupted datasets are not affected. The backend returns 200 with an informational row for those, and that still renders as before.
Also added a CHANGELOG entry under Unreleased.
Test plan
node --check web/vanilla/app.jsFixes #27