Feature/40 allow multiple query params#42
Open
wdolek wants to merge 6 commits intolamchakchan:masterfrom
Open
Conversation
wdolek
force-pushed
the
feature/40-allow-multiple-query-params
branch
from
11cf156 to
82fd095
Compare
|
This doesn't quite work as intended. I've fixed it and written a test case to demonstrate. I've made that a pull request to wdolek's branch. I'm a git noob, so I apologize if this is not how you fix a problem on a pull request. |
…eCollection class that prints the string correctly and added test to verify results. (#1)
… key; Improve test case
Author
|
@DayneD89, I dared to simplify code from you - removing LINQ, keeping it simple and also extended test case. (It would be enough to test extension method itself, but I kept your test which uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing multiple query params (cookies and headers) of same name (#40) by using
NameValueCollectioninstead ofDictionary<string, string>. RFC allows multiple values for all query params, headers and even cookies.@lamchakchan, I wasn't able to run all tests - I'm not able to access
data.gov, andnekudo.comis deprecated (you need newly get free API key in order to call geoip API fromipapi).I didn't do more testing yet, but please have a look and let me know if you find something. Once I have more time I will confirm whether everything works as expected.