Skip to content

Alys/increase tests #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alysbrooks wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Alys/increase tests #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0ba506
Increase tests for RE2 property-based test.
alysbrooks Oct 20, 2021
1c99b4f
Catch StackOverflowErrors.
alysbrooks Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/lambdaisland/regal/re2_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
(catch Exception _
false)))

(defspec re2-matches-like-java 10
(defspec re2-matches-like-java 100
(with-redefs [regal-spec/token-gen #(s/gen (disj regal-spec/known-tokens :line-break :start :end))]
(prop'/for-all [regal (s/gen ::regal/form)
:when (can-generate? regal)
Expand All @@ -37,6 +37,8 @@
:let [java-result
(try (re-find (regal/regex regal) s)
(catch Exception _
:fai)
(catch StackOverflowError _
:fail))]
:when (not= :fail java-result)]
(is (= java-result
Expand Down