Fix: Correctly analyze defstyled by transforming to def forms in the hook (issue #31) #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the defstyled clj-kondo analysis hook to correctly handle all permutations of the macro, resolving an issue: a runtime exception.
Bug Fixes: Resolved ClassCastException (java.lang.Boolean cannot be cast to clojure.lang.Associative)
The original hook implementation returned {:node true} in the branch where fn-tag was not a list (i.e., when the style definition lacked a function body).
clj-kondo expects a valid AST node (an Associative data structure) in the :node key. Returning a boolean caused the parser to fail at the namespace level.
Fix: The false branch now correctly returns the AST for the original node, preventing the exception.