This repository was archived by the owner on Mar 13, 2026. It is now read-only.
Open
Conversation
fmoletta
reviewed
Jul 26, 2023
jrchatruc
reviewed
Jul 27, 2023
jrchatruc
reviewed
Jul 27, 2023
jrchatruc
reviewed
Jul 27, 2023
Collaborator
|
Give an example of an actual simple cairo assembly instruction and how it encodes to bytecode, something like |
jrchatruc
suggested changes
Jul 27, 2023
Collaborator
jrchatruc
left a comment
jrchatruc
left a comment
There was a problem hiding this comment.
Left a bunch of comments
jrchatruc
reviewed
Aug 2, 2023
| }; | ||
| ``` | ||
| to extract the dst_reg flag we can define a mask 'DST_REG_MASK' with value 0x0001 and and a padding 'DST_REG_OFF' with value 0 because it is the less significant bit, then we can perform the operation | ||
| '(((encoded_instr) >> 48) & DST_REG_MASK) >> DST_REG_OFF' to obtain the dst_reg flag. We shifted 48 bits first because there is where the flags start. |
Collaborator
There was a problem hiding this comment.
This code is not rendering well because you are using ' to enclose it instead of `. Consider changing it or just moving to a code block with using ```
The same goes for a bunch of code and instructions mentioned shown above
jrchatruc
reviewed
Aug 2, 2023
jrchatruc
reviewed
Aug 2, 2023
Oppen
reviewed
Aug 3, 2023
Oppen
reviewed
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.