Skip to content

Please add async option. #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georgii-ivanov wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Please add async option. #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35c12f3
Please add async option.
Nov 11, 2016
965d5a2
Update transport.js
Nov 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/transport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export class Basic extends Transport {
send(request, url, options) {
return co(function *() {
let sandbox = options && options.sandbox;
let asynchronous = options && options.async !== undefined ? options.async : true;
let transformRequest = request.transformRequest;
let transformResponse = request.transformResponse;
let onerror = request.onerror;
Expand All @@ -44,7 +45,7 @@ export class Basic extends Transport {
xhr.open(
request.method,
url,
true /* async */,
asynchronous,
this.credentials.username,
this.credentials.password
);
Expand Down Expand Up @@ -76,6 +77,7 @@ export class OAuth2 extends Transport {
send(request, url, options={}) {
return co(function *() {
let sandbox = options.sandbox;
let asynchronous = options && options.async !== undefined ? options.async : true;
let transformRequest = request.transformRequest;
let transformResponse = request.transformResponse;
let onerror = request.onerror;
Expand All @@ -87,7 +89,7 @@ export class OAuth2 extends Transport {
let token = yield access(this.credentials, options);
xhr = new XMLHttpRequest();
if (sandbox) sandbox.add(xhr);
xhr.open(request.method, url, true /* async */);
xhr.open(request.method, url, asynchronous);
xhr.setRequestHeader('Authorization', `Bearer ${token}`);
if (transformRequest) transformRequest(xhr);
yield xhr.send(request.requestData);
Expand Down Expand Up @@ -132,9 +134,10 @@ function isExpired(credentials) {

let getAccessToken = co.wrap(function *(credentials, options) {
let sandbox = options.sandbox;
let asynchronous = options && options.async !== undefined ? options.async : true;
let xhr = new XMLHttpRequest();
if (sandbox) sandbox.add(xhr);
xhr.open('POST', credentials.tokenUrl, true /* async */);
xhr.open('POST', credentials.tokenUrl, asynchronous);
xhr.setRequestHeader('Content-Type', 'application/x-www-form-urlencoded');

let data = querystring.stringify({
Expand Down