Fix/atol rtol alignment#262
Open
m-messer wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The atol and rtol tolerance checks in the symbolic and physical quantity evaluators used inconsistent, non-standard logic: they treated atol and rtol as separate independent conditions (both had to pass), used the answer as the rtol reference in some places and the response in others, and used strict < rather than <=.
Solution: Align both evaluators with NumPy's isclose formula: |ans - res| <= atol + rtol * |ans|, where ans is the reference value. This combines atol and rtol into a single tolerance bound, matches the behaviour users familiar with NumPy would expect, and is consistent with isSimilar in other tools.
Changes: