Skip to content

Added possibility to add range of values as a grading parameter #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KarlLundengaard wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added possibility to add range of values as a grading parameter #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,16 @@ def evaluation_function(response, answer, params) -> dict:
to output the grading response.
"""

rtol = params.get("rtol", 0)
atol = params.get("atol", 0)
if isinstance(answer, list):
rtol = 0
atol = (answer[1]-answer[0])/2
answer = (answer[1]+answer[0])/2
else:
rtol = params.get("rtol", 0)
atol = params.get("atol", 0)

is_correct = None
real_diff = None

real_diff = abs(response - answer)
allowed_diff = atol + rtol * abs(answer)
is_correct = real_diff <= allowed_diff
Expand Down
12 changes: 12 additions & 0 deletions app/evaluation_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,18 @@ def test_relative_absolute_incorrect(self):

self.assertEqual(response.get("is_correct"), False)

def test_range_in_answer(self):
response = 1e6
params = {}

answer = [1e5,3e7]
result = evaluation_function(response, answer,params)
self.assertEqual(result.get("is_correct"), True)

answer = [1e5,5e5]
result = evaluation_function(response, answer,params)
self.assertEqual(result.get("is_correct"), False)


if __name__ == "__main__":
unittest.main()