Refactor error field synchronization with helper methods#29
Merged
lainio merged 4 commits intolainio:masterfrom Sep 2, 2025
Merged
Refactor error field synchronization with helper methods#29lainio merged 4 commits intolainio:masterfrom
lainio merged 4 commits intolainio:masterfrom
Conversation
lainio
reviewed
Sep 1, 2025
Owner
|
Thank you! I like this. I added a comment about the name of the function. Let's start the discussion 😃 |
lainio
reviewed
Sep 1, 2025
lainio
approved these changes
Sep 2, 2025
Owner
lainio
left a comment
There was a problem hiding this comment.
Works for me, and the test matrix is green. I also ran make inline_hander for checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates error field synchronization by adding error setting methods that ensures i.Err and i.werr are always kept in sync.
Changes
Benefits
Testing