Skip to content

Fixing compilation failure when visp_gui is deactivated #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fspindle merged 1 commit into from
Jan 27, 2026
Merged

Fixing compilation failure when visp_gui is deactivated #1893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions modules/tracker/rbt/src/rendering/vpPanda3DDepthFilters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@
#include "graphicsEngine.h"
#include "windowFramework.h"

#include <visp3/gui/vpDisplayFactory.h>

BEGIN_VISP_NAMESPACE
#define VP_STRINGIFY(x) #x
#define VP_TOSTRING(x) VP_STRINGIFY(x)
Expand Down
2 changes: 2 additions & 0 deletions modules/tracker/rbt/test/catchRBTDataset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,12 +259,14 @@ SCENARIO("Running tracker on sequences with ground truth", "[rbt]")
vpImage<unsigned char> displayI(h, w), displayDepth(h, w, 255), displayMask(h, w);
vpImage<vpRGBa> displayRGB(h, w);

#ifdef VISP_HAVE_MODULE_GUI
std::vector<std::shared_ptr<vpDisplay>> displays = vpDisplayFactory::makeDisplayGrid(2, 2, 0, 0, 70, 70,
"Gray", displayI,
"Color", displayRGB,
"Depth", displayDepth,
"Mask", displayMask
);
#endif

const std::vector<std::string> objectNames = { "dragon", "cube", "stomach", "lower_teeth" };

Expand Down
2 changes: 2 additions & 0 deletions modules/tracker/rbt/test/test_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
#include <visp3/ar/vpPanda3DGeometryRenderer.h>
#include <visp3/ar/vpPanda3DRGBRenderer.h>

#ifdef VISP_HAVE_MODULE_GUI
#include <visp3/gui/vpDisplayFactory.h>
#endif

#include <vector>

Expand Down
6 changes: 4 additions & 2 deletions modules/vision/test/keypoint-with-dataset/testKeyPoint-2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@

#include <visp3/core/vpImage.h>
#include <visp3/core/vpIoTools.h>
#ifdef VISP_HAVE_MODULE_GUI
#include <visp3/gui/vpDisplayFactory.h>
#endif
#include <visp3/io/vpImageIo.h>
#include <visp3/io/vpParseArgv.h>
#include <visp3/io/vpVideoReader.h>
Expand Down Expand Up @@ -174,7 +176,7 @@ void run_test(const std::string &env_ipath, bool opt_click_allowed, bool opt_dis
vpDisplay *display = nullptr;

if (opt_display) {
#ifdef VISP_HAVE_DISPLAY
#if defined(VISP_HAVE_DISPLAY) && defined(VISP_HAVE_MODULE_GUI)
display = vpDisplayFactory::allocateDisplay(I, 0, 0, "ORB keypoints matching and pose estimation");
display->setDownScalingFactor(vpDisplay::SCALE_AUTO);
#else
Expand Down Expand Up @@ -324,7 +326,7 @@ void run_test(const std::string &env_ipath, bool opt_click_allowed, bool opt_dis
keypoints.createImageMatching(I, IMatching);

if (opt_display) {
#ifdef VISP_HAVE_DISPLAY
#if defined(VISP_HAVE_DISPLAY) && defined(VISP_HAVE_MODULE_GUI)
display2 = vpDisplayFactory::allocateDisplay(IMatching, 0, static_cast<int>(I.getHeight()) / vpDisplay::getDownScalingFactor(I) + 30, "IMatching");
display2->setDownScalingFactor(vpDisplay::SCALE_AUTO);
#endif
Expand Down
4 changes: 3 additions & 1 deletion modules/vision/test/keypoint-with-dataset/testKeyPoint-3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@

#include <visp3/core/vpImage.h>
#include <visp3/core/vpIoTools.h>
#if defined(VISP_HAVE_MODULE_GUI)
#include <visp3/gui/vpDisplayFactory.h>
#endif
#include <visp3/io/vpImageIo.h>
#include <visp3/io/vpParseArgv.h>
#include <visp3/io/vpVideoReader.h>
Expand Down Expand Up @@ -201,7 +203,7 @@ void run_test(const std::string &env_ipath, bool opt_click_allowed, bool opt_dis
vpDisplay *display = nullptr;

if (opt_display) {
#ifdef VISP_HAVE_DISPLAY
#if defined(VISP_HAVE_DISPLAY) && defined(VISP_HAVE_MODULE_GUI)
display = vpDisplayFactory::allocateDisplay(Imatch, 0, 0, "ORB keypoints matching");
display->setDownScalingFactor(vpDisplay::SCALE_AUTO);
#else
Expand Down
4 changes: 3 additions & 1 deletion modules/vision/test/keypoint-with-dataset/testKeyPoint-4.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@
#include <visp3/core/vpHomogeneousMatrix.h>
#include <visp3/core/vpImage.h>
#include <visp3/core/vpIoTools.h>
#if defined(VISP_HAVE_MODULE_GUI)
#include <visp3/gui/vpDisplayFactory.h>
#endif
#include <visp3/io/vpImageIo.h>
#include <visp3/io/vpParseArgv.h>
#include <visp3/io/vpVideoReader.h>
Expand Down Expand Up @@ -175,7 +177,7 @@ void run_test(const std::string &env_ipath, bool opt_click_allowed, bool opt_dis
Imatch.resize(I.getHeight(), 2 * I.getWidth());
Imatch.insert(I, vpImagePoint(0, 0));

#ifdef VISP_HAVE_DISPLAY
#if defined(VISP_HAVE_DISPLAY) && defined(VISP_HAVE_MODULE_GUI)
display = vpDisplayFactory::allocateDisplay(I, 0, 0, "ORB keypoints matching");
display->setDownScalingFactor(vpDisplay::SCALE_AUTO);
display2 = vpDisplayFactory::allocateDisplay(Imatch, 0, static_cast<int>(I.getHeight()) / vpDisplay::getDownScalingFactor(I) + 40, "ORB keypoints matching");
Expand Down
4 changes: 3 additions & 1 deletion modules/vision/test/keypoint-with-dataset/testKeyPoint-5.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@

#include <visp3/core/vpImage.h>
#include <visp3/core/vpIoTools.h>
#if defined(VISP_HAVE_MODULE_GUI)
#include <visp3/gui/vpDisplayFactory.h>
#endif
#include <visp3/io/vpImageIo.h>
#include <visp3/io/vpParseArgv.h>
#include <visp3/vision/vpKeyPoint.h>
Expand Down Expand Up @@ -158,7 +160,7 @@ void run_test(const std::string &env_ipath, bool opt_click_allowed, bool opt_dis
vpDisplay *display = nullptr;

if (opt_display) {
#ifdef VISP_HAVE_DISPLAY
#if defined(VISP_HAVE_DISPLAY) && defined(VISP_HAVE_MODULE_GUI)
display = vpDisplayFactory::allocateDisplay(I, 0, 0, "KeyPoints detection.");
#else
std::cout << "No image viewer is available..." << std::endl;
Expand Down
4 changes: 3 additions & 1 deletion modules/vision/test/keypoint-with-dataset/testKeyPoint-6.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@

#include <visp3/core/vpImage.h>
#include <visp3/core/vpIoTools.h>
#if defined(VISP_HAVE_MODULE_GUI)
#include <visp3/gui/vpDisplayFactory.h>
#endif
#include <visp3/io/vpImageIo.h>
#include <visp3/io/vpParseArgv.h>
#include <visp3/vision/vpKeyPoint.h>
Expand Down Expand Up @@ -204,7 +206,7 @@ void run_test(const std::string &env_ipath, bool opt_click_allowed, bool opt_dis
vpDisplay *display = nullptr;

if (opt_display) {
#ifdef VISP_HAVE_DISPLAY
#if defined(VISP_HAVE_DISPLAY) && defined(VISP_HAVE_MODULE_GUI)
display = vpDisplayFactory::allocateDisplay(I, 0, 0, "KeyPoints detection.");
#else
std::cout << "No image viewer is available..." << std::endl;
Expand Down
4 changes: 3 additions & 1 deletion modules/vision/test/keypoint-with-dataset/testKeyPoint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@

#include <visp3/core/vpImage.h>
#include <visp3/core/vpIoTools.h>
#if defined(VISP_HAVE_MODULE_GUI)
#include <visp3/gui/vpDisplayFactory.h>
#endif
#include <visp3/io/vpImageIo.h>
#include <visp3/io/vpParseArgv.h>
#include <visp3/io/vpVideoReader.h>
Expand Down Expand Up @@ -178,7 +180,7 @@ void run_test(const std::string &env_ipath, bool opt_click_allowed, bool opt_dis
vpDisplay *display = nullptr;

if (opt_display) {
#ifdef VISP_HAVE_DISPLAY
#if defined(VISP_HAVE_DISPLAY) && defined(VISP_HAVE_MODULE_GUI)
display = vpDisplayFactory::allocateDisplay(Imatch, 0, 0, "ORB keypoints matching");
display->setDownScalingFactor(vpDisplay::SCALE_AUTO);
#else
Expand Down
Loading