Skip to content

fix: resetting bg color now also resets foreground/accent color #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lacymorrow wants to merge 1 commit into from
Closed

fix: resetting bg color now also resets foreground/accent color #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
### 2026-05-16
- fix: resetting bg color now also resets foreground/accent color ([LAC-1313](https://github.com/lacymorrow/xover/issues/3))

### 2024-12-19
- Feature: SVG circle demo crosshair added
- Improvements: Enhanced crosshair rendering and positioning
Expand Down
17 changes: 11 additions & 6 deletions src/main/crossover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,17 +347,22 @@ const syncSettings = ( options = preferences.preferences ) => {
'--circle-thickness': options.crosshair.circleThickness,
}

// App color is set
// App colors — highlight only applies when bg is also set; resetting bg resets highlight too

if ( options.app.appHighlightColor.charAt( 0 ) === '#' ) {
if ( options.app.appBgColor.charAt( 0 ) === '#' ) {

properties['--app-highlight-color'] = options.app.appHighlightColor
properties['--app-bg-color'] = hexToRgbA( options.app.appBgColor, APP_BACKGROUND_OPACITY )

}
if ( options.app.appHighlightColor.charAt( 0 ) === '#' ) {

if ( options.app.appBgColor.charAt( 0 ) === '#' ) {
properties['--app-highlight-color'] = options.app.appHighlightColor

properties['--app-bg-color'] = hexToRgbA( options.app.appBgColor, APP_BACKGROUND_OPACITY )
}

} else if ( options.app.appHighlightColor !== 'unset' ) {

// bg was reset to default — clear orphaned highlight color so buttons stay visible
preferences.value( 'app.appHighlightColor', 'unset' )

}

Expand Down
Loading