Add security status display for Secure LSL streams #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add security_enabled and security_fingerprint fields to StreamItem - Display lock emoji prefix for encrypted streams in stream list - Update info_to_listName to include security status - Requires liblsl with security API (lsl_get_security_enabled)
Display security version information (base version, security version, full version) in the About dialog when using liblsl-secure.
- Detect security mismatches before recording starts - Show clear error dialog with stream names in blue, red warning text - Provide actionable instructions (run lsl-keygen or import credentials) - Add error reporting infrastructure to recording class for future use - Move lock icon to end of stream name for better readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for displaying security status of LSL streams when using Secure LSL (sccn/secureLSL).
Dependencies
This PR requires the secure liblsl library from sccn/secureLSL (currently private, pending review).
Documentation: https://secure-lsl.pages.dev
Note
This is a draft PR. The secureLSL repository is not yet public; this PR is submitted for early review and discussion alongside the main secureLSL proposal for liblsl v2.