fix: unblock cluster deletion from legacy finalizers#36
Merged
wallyxjh merged 1 commit intoJun 9, 2026
Merged
Conversation
wallyxjh
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two legacy finalizer cases that can block Cluster deletion on v0.9.3:
PodDisruptionBudgetin the Component deletion plan so legacy PDBs withcluster.kubeblocks.io/finalizercan be cleaned up.dataprotection.kubeblocks.io/finalizerfrom failed backup Jobs when the owning Backup no longer exists.Also sync PDB RBAC into both generated RBAC and Helm chart RBAC.
Why
Some old clusters can stay in
Deletingeven after Pods, InstanceSets, PVCs, Jobs, and other visible resources are gone. Two observed blockers were:cluster.kubeblocks.io/finalizer.dataprotection.kubeblocks.io/finalizer, while the Backup object no longer exists.