fix: skip postProvision for stopped components#35
Merged
wallyxjh merged 1 commit intoJun 9, 2026
Conversation
Skip component postProvision reconciliation when the component is already stopped via spec.stop or the legacy replicas=0 stop path. This prevents RuntimeReady postProvision actions from blocking stop reconciliation after the workload has been scaled down to zero pods. Do not mark postProvision as done when skipping, so the action can still run after the component is started again if the done annotation is absent. Add regression coverage for RuntimeReady, stop=true, and replicas=0 cases.
wallyxjh
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip component postProvision reconciliation when the component is already stopped via spec.stop or the legacy replicas=0 stop path. This prevents RuntimeReady postProvision actions from blocking stop reconciliation after the workload has been scaled down to zero pods.
Do not mark postProvision as done when skipping, so the action can still run after the component is started again if the done annotation is absent. Add regression coverage for RuntimeReady, stop=true, and replicas=0 cases.