refactor(BA-3764): add Purger pattern to Domain repository #8525
+370
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size:L
MinJuTur
commented
Feb 2, 2026
Comment on lines
108
to
114
| async def soft_delete_domain(self, domain_name: str) -> None: | ||
| """ | ||
| Soft deletes a domain by setting is_active to False. | ||
| Validates domain deletion permissions. | ||
| """ | ||
| async with self._db.begin() as conn: |
Contributor
Author
There was a problem hiding this comment.
soft_delete_domain() still uses SAConnection. Only purge_domain() and its helper methods were migrated to SASession in this PR.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors domain deletion to use the BatchPurger pattern, migrating from Core SQLAlchemy operations (AsyncConnection) to ORM operations (AsyncSession). This brings consistency with other repositories in the codebase that have already adopted this pattern (e.g., GroupRepository, UserRepository).
Changes:
- Introduced
DomainKernelBatchPurgerSpecandDomainBatchPurgerSpecfor structured batch deletion operations - Migrated
purge_domain()and helper methods fromAsyncConnectiontoAsyncSession - Added integration tests for the new purger specifications
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/ai/backend/manager/repositories/domain/purgers.py | New file defining batch purger specs for domain and kernel deletions, following the established pattern in the codebase |
| src/ai/backend/manager/repositories/domain/repository.py | Updated purge_domain() to use BatchPurger pattern; migrated helper methods from Core (AsyncConnection) to ORM (AsyncSession); updated imports to use Row classes instead of table objects |
| tests/unit/manager/repositories/domain/test_domain_purgers.py | New integration tests for domain purger specs with comprehensive fixture setup and assertions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MinJuTur
commented
Feb 2, 2026
| from ai.backend.manager.models.utils import ExtendedAsyncSAEngine | ||
|
|
||
|
|
||
| class TestDomainPurgersIntegration: |
Contributor
Author
There was a problem hiding this comment.
The initial plan included keypair_resource_policy, sample_keypair, and sample_scaling_group fixtures, but they turned out to be unnecessary for these purger spec tests. So I excluded them.
jopemachine
reviewed
Feb 2, 2026
jopemachine
reviewed
Feb 2, 2026
jopemachine
reviewed
Feb 3, 2026
jopemachine
reviewed
Feb 3, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Replace raw SQL deletion with BatchPurger pattern in DomainRepository.purge_domain() for consistent and maintainable domain data deletion. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Align with the group test convention where sample_domain returns a plain string instead of DomainRow object. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
asyncio_mode = "auto" is configured in pyproject.toml, making explicit @pytest.mark.asyncio decorators redundant. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…sionMap
Fix test fixtures to use ResourceSlot({}) and VFolderHostPermissionMap({})
instead of plain dict, as the model columns now require these types.
Also remove @pytest.mark.asyncio decorators (asyncio_mode=auto).
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
MinJuTur
force-pushed
the
refactor/BA-3764-add-purger-pattern-to-domain-repository
branch
from
046eb72 to
85fb1cc
Compare
HyeockJinKim
approved these changes
Feb 3, 2026
jopemachine
deleted the
refactor/BA-3764-add-purger-pattern-to-domain-repository
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BatchPurgerpattern inDomainRepository.purge_domain()for domain-related deletionsDomainKernelBatchPurgerSpecandDomainBatchPurgerSpecfor batch deletion of kernels and domainspurge_domain()and related helper methods fromSAConnection(Core) toSASession(ORM)Related Issue
Test plan
pants lint src/ai/backend/manager/repositories/domain::pants check src/ai/backend/manager/repositories/domain::pants test tests/unit/manager/repositories/domain::🤖 Generated with Claude Code